Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for inotify limits on linux for quickstart #289

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abangser
Copy link
Member

@abangser abangser commented Dec 2, 2024

This was raised as a blocker by a new user. I have decided not to actively set the limits for them, but to instead alert them if there is an issue and give them the tools to solve it. This is because I assume people wouldn't like these kinds of limits to be set automatically.

So far I have:

  • tested individual commands on linux docker containers locally
  • verified mac installation continues to work locally
  • bodged together a test in docker locally to see the command ran correctly
  • verified on linux in CI (including lowering minimum limits to match what we run with on CI)

Before merging I want to:

  • verify decision to alert rather than fix the issue with the original user
  • verify a working solution with the original user
  • see if @hatofmonkeys can give this a whirl as he runs Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant