Cleanup source_t codebase & fix usage
#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrXiao
reviewed
Apr 27, 2025
ChAoSUnItY
force-pushed
the
fix/source_ext
branch
from
73b8449 to
5ae62a1
Compare
jserv
reviewed
Apr 28, 2025
Previously SOURCE is overhauled with a dynamic array implementation, but parser.c and inliner.c didn't actually benefited from it, and could still cause overflow if size exceeds capacity. In this patch, now extending source_t respects computed result size and expands if need. inliner.c's implementation is now also replaced with dynamic array implementation. Additionally, few functions are renamed to keep function naming convention.
ChAoSUnItY
force-pushed
the
fix/source_ext
branch
from
5ae62a1 to
8a7ffda
Compare
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
SOURCEis overhauled with a dynamic array implementation, butparser.candinliner.cdidn't actually benefited from it, and could still cause overflow if size exceeds capacity.In this patch, now extending
source_trespects computed result size and expands if need.inliner.c's implementation is now also replaced with dynamic array implementation.Additionally, few functions are renamed to keep function naming convention.
Summary by Bito
This pull request enhances the `source_t` structure by implementing a dynamic array for better memory management and preventing overflow issues. It also renames several functions for consistency, improving code clarity and maintainability across `parser.c` and `inliner.c`.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily involve structural improvements and renaming, making the review process relatively simple.