Skip to content

Commit

Permalink
scripts: Remove explicit rustup self update
Browse files Browse the repository at this point in the history
Commit 17f8e37 ("Convert toolchain file to TOML syntax") switched
from the bare toolchain file to the TOML-based one for better management
of the toolchain and components used.

Commit 1cb61e6 ("deps.sh: Update rustup or inform user of env
vars") added an explicit `rustup self update` because there were still
cases, a year later, of people not having a rustup new enough to support
the TOML-based toolchain file.

Now 2 years after that, it should be safe to drop the explicit self
update. The TOML format has widespread adoption and rustup now self
updates by default. This should allow distro-provided rustup, which
disables the self update feature, to work if it is already installed in
place of the one downloaded from https://rustup.rs.

Signed-off-by: Tim Crawford <[email protected]>
  • Loading branch information
crawfxrd committed Mar 5, 2024
1 parent 8af7fd5 commit dcab9f7
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions scripts/deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,7 @@ msg "Installing git hooks"
make git-config

RUSTUP_NEW_INSTALL=0
if which rustup &> /dev/null; then
msg "Updating rustup"
rustup self update
else
if ! command -v rustup >/dev/null 2>&1; then
RUSTUP_NEW_INSTALL=1
msg "Installing Rust"
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs \
Expand Down

0 comments on commit dcab9f7

Please sign in to comment.