kbscan: Work around IT8587E hang #493
Merged
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IT8587E is hanging when reading the keyboard matrix. - Increasing the delay does not fix it - Placing delays between KSO* writes does not fix it - Code generated by SDCC looks valid to me Rewriting it like this does fix it, although I don't know why. Signed-off-by: Tim Crawford <tcrawford@system76.com>
leviport
approved these changes
Jul 25, 2024
|
Just installed/tested this, and I can confirm that on my laptop as well, this seems to resolve the crashes with no (noticeable) negative effects whatsoever. I tried running various commands that caused crashes on the previous build and booting into kernels that caused crashes before, and none of them now result in a crash anymore. 👍 |
mmstick
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IT8587E is hanging when reading the keyboard matrix.
KSO*writes does not fix itRewriting it like this does fix it, although I don't know why.
Tested on darp5 with WDT enabled:
Resolves: #472