-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model numbers for more batteries #220
Conversation
I got all the ones that were visible in internal pictures, plus the cartridge battery in bonw14. There are a few more cartridge batteries I want to add as well. |
b426019
to
6e9fdd9
Compare
I think that's everything. I also made the battery spec format more consistent, based on the ones that already had battery model numbers. The only oddballs are oryp9/10 and serw13 since the 15" and 17" had slightly different batteries with different model numbers. Also threw in a minor correction on the addw1 tech specs (CPU said it was U-class, I corrected it to H-class). It might be easier to rebase master into this after Spark is merged, so feel free to leave this until that is in. |
a2df97d
to
6ccefdb
Compare
Totally, I think that looks better too. I actually set out doing it like that, but I found more instances of it in parentheses, so I just unified based off of what was already more prevalent. |
6ccefdb
to
15e3b7a
Compare
Co-authored-by: leviport <[email protected]>
15e3b7a
to
151c4e0
Compare
Since this PR has a few unrelated fixes, it needs to be rebased and merged (not squashed). It's probably best if someone else reviews this now since I've made significant changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each change looks accurate, and the battery information appears correct on every system I checked against.
No description provided.