Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model numbers for more batteries #220

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Add model numbers for more batteries #220

merged 4 commits into from
Nov 29, 2023

Conversation

leviport
Copy link
Member

@leviport leviport commented Nov 9, 2023

No description provided.

@leviport
Copy link
Member Author

leviport commented Nov 9, 2023

I got all the ones that were visible in internal pictures, plus the cartridge battery in bonw14. There are a few more cartridge batteries I want to add as well.

@leviport
Copy link
Member Author

leviport commented Nov 9, 2023

I think that's everything. I also made the battery spec format more consistent, based on the ones that already had battery model numbers. The only oddballs are oryp9/10 and serw13 since the 15" and 17" had slightly different batteries with different model numbers.

Also threw in a minor correction on the addw1 tech specs (CPU said it was U-class, I corrected it to H-class).

It might be easier to rebase master into this after Spark is merged, so feel free to leave this until that is in.

@leviport leviport marked this pull request as ready for review November 9, 2023 17:53
@leviport leviport requested review from a team November 9, 2023 17:53
@jacobgkau jacobgkau self-assigned this Nov 9, 2023
@jacobgkau
Copy link
Member

The kudu6 section was one of the more recent ones, and I'm thinking having the model number as a sub-bullet looks better than having it in parenthesis.

image

I'm going to go ahead and make that the formatting for all of them, if you're okay with that.

@leviport
Copy link
Member Author

Totally, I think that looks better too. I actually set out doing it like that, but I found more instances of it in parentheses, so I just unified based off of what was already more prevalent.

@jacobgkau
Copy link
Member

Since this PR has a few unrelated fixes, it needs to be rebased and merged (not squashed).

It's probably best if someone else reviews this now since I've made significant changes.

Copy link

@XV-02 XV-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each change looks accurate, and the battery information appears correct on every system I checked against.

@leviport leviport merged commit 97a0240 into master Nov 29, 2023
1 check passed
@leviport leviport deleted the battery-models branch November 29, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants