handle renegotiation with streams correctly

t-mullen · Jan 6, 2019 · 9b33e99 · 9b33e99
1 parent 24adb50
commit 9b33e99
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/client/package.json b/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simple-signal-client",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "socket.io signalling solution for simple-peer",
   "main": "src/index.js",
   "author": "Thomas Mullen",

diff --git a/client/src/index.js b/client/src/index.js
@@ -80,6 +80,7 @@ SimpleSignalClient.prototype.connect = function (target, metadata = {}, peerOpti
   peerOptions.initiator = true
 
   const sessionId = cuid() // TODO: Use crypto
+  var firstOffer = true
   const peer = this._peers[sessionId] = new SimplePeer(peerOptions)
 
   peer.on('close', () => {
@@ -88,7 +89,8 @@ SimpleSignalClient.prototype.connect = function (target, metadata = {}, peerOpti
   })
 
   peer.on('signal', (signal) => {
-    const messageType = signal.sdp ? 'simple-signal[offer]' : 'simple-signal[signal]'
+    const messageType = signal.sdp && firstOffer ? 'simple-signal[offer]' : 'simple-signal[signal]'
+    if (signal.sdp) firstOffer = false
     this.socket.emit(messageType, {
       signal, metadata, sessionId, target
     })

diff --git a/server/package.json b/server/package.json
@@ -1,6 +1,6 @@
 {
   "name": "simple-signal-server",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "socket.io signalling solution for simple-peer",
   "main": "src/index.js",
   "author": "Thomas Mullen",