chore: convert workbook tests to pytest #1645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorwoods
force-pushed
the
jorwoods/pytestify_workbook
branch
from
1ac12a2 to
0ab3cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSC already uses pytest as its testing framework, this PR converts the individual tests from using
unittestto using pytest and its fixtures. Using fixtures will allow more precise control over the scoping of dependencies.Favoring pytest style tests will also allow use of parameterize and other advanced pytest features. It also allows using the simpler
assertinstead of unittest'sassertEqual,assertTrue, and others. This makes writing tests in the future simpler and more consistent.Also striving for consistency, this PR changes all of the test assets to be
Pathobjects, allowing easier reading of the payload.