feat: integrated utils.condensePath into utils.which #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed tabrindle#151 Removed `utils.condensePath` and updated all references to use the enhanced `utils.which`, which now replaces the home directory with ~. Updated and added tests to ensure functionality.
this is really a bad idea the way I see it. Can you revert this part. |
|
Thank you for your feedback. I understand your concern about replacing the home directory with ~. Could you please elaborate on the issues you foresee with this approach? My initial reasoning was to ensure consistency across various environments and to obscure user-specific paths. However, I am open to reverting this change if there are significant drawbacks. Looking forward to your detailed input so we can find the best solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #151
Removed
utils.condensePathand updated all references to use the enhancedutils.which, which now replaces the home directory with ~. Updated and added tests to ensure functionality.