Skip to content

Fix caldav example #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix caldav example #396

wants to merge 1 commit into from

Conversation

kornelski
Copy link

@kornelski kornelski commented Jun 19, 2022

BytesStart::unescape_and_decode on <D:href> element is returning "D:href", which isn't the URL. The URL is in the text nodes of the element.

This mistake was caused by the wrong API: #397

@Mingun
Copy link
Collaborator

Mingun commented Jun 19, 2022

Thanks for contribution. I think, the example could be even more useful if you add an assert_eq! in the main with the expected result. Would you like to do that?

Also, you should run cargo fmt.

@Mingun Mingun added the documentation Issues about improvements or bugs in documentation label Jun 19, 2022
@kornelski
Copy link
Author

Sorry, I don't use rustfmt. I think it makes too many formatting mistakes, and the tool is not good enough to be used uncritically. It's especially annoying when it's used to block CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues about improvements or bugs in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants