forked from uselagoon/build-deploy-tool
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.23.0 update #3
Open
MaxCWhitehead
wants to merge
27
commits into
tag1consulting:tag1-main
Choose a base branch
from
MaxCWhitehead:2.23.0-update
base: tag1-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2.23.0 update #3
MaxCWhitehead
wants to merge
27
commits into
tag1consulting:tag1-main
from
MaxCWhitehead:2.23.0-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default retention keeps weekly backups which means the default of keeping one monthly is redundant. This can be confusing when you dont get "a monthly" backup avaialable. restic/restic#2747 (comment) > Especially that `--keep-X 1` doesn't add anything if another option for a > smaller interval is used. This is quite counter-intuitive for me (intuitive > counting doesn't start at 2)!
…faults refactor: default k8up retention is confusing
* refactor: add tests for LAGOON_BACKUP_PROD_SCHEDULE * test: fix retention in testfile --------- Co-authored-by: Ben Jackson <[email protected]>
…goon#378) * Adds ability to specify tags in refreshimages * removes println * refactor: just use one tag with variable replacement * test: add test with lagoon and docker-compose files --------- Co-authored-by: Blaize Kaye <[email protected]> Co-authored-by: shreddedbacon <[email protected]>
* fix: lagoon.persistent.name override checks * test: fix autogenroutes after modifying service label checks * fix: use persistent name as volume name * test: add a complex persistent test
…goon#377) * chore: remove unused crontab script * refactor: move pre-rollout tasks to before templating/rollouts
…selagoon#340) * feat: implement feature to start failing builds on docker-compose yaml errors * feat: implement feature to start failing builds on docker-compose yaml errors
feat: add valkey service type
…heck chore: remove slow capabilities check
…text feat(fix): set runasuser podsecuritycontext for backup schedules
Conflicts resolved: cmd/template_lagoonservices_test.go internal/generator/buildvalues.go
Conflicts: internal/templating/templates_deployment.go - upstream fixed linked container resources not set from build values, we do that and override from service values if necessary internal/templating/test-resources/deployment/result-nginx-php-resources-1.yaml - moved folder
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge upstream changes from 2.22.0 and 2.23.0. Minor conflicts in tests / files moving around.
Tests are passing. Will push tags for these two versions once merged.