Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] External deps & imgui #8655

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

johnnynunez
Copy link

This pull request includes updates to several submodules and a minor code improvement in the taichi project. The most important changes include updating the submodule branches and commits, and improving the null check in IRVerifier.

Submodule updates:

  • .gitmodules: Updated the external/eigen submodule to use branch 3.4 instead of 3.3.
  • external/DirectX-Headers: Updated the submodule commit to 3ae9c7692ddecc9107d401fdf7999b34a8b8079b.
  • external/FP16: Updated the submodule commit to 98b0a46bce017382a6351a19577ec43a715b6835.
  • external/PicoSHA2: Updated the submodule commit to 27fcf6979298949e8a462e16d09a0351c18fcaf2.
  • external/SPIRV-Cross: Updated the submodule commit to 2c32b6bf86f3c4a5539aa1f0bacbd59fe61759cf.
  • external/SPIRV-Headers: Updated the submodule commit to 54a521dd130ae1b2f38fef79b09515702d135bdd.
  • external/SPIRV-Reflect: Updated the submodule commit to c637858562fbce1b6f5dc7ca48d4e8a5bd117b70.
  • external/SPIRV-Tools: Updated the submodule commit to bb86786ed9aa6576a1fb72a9eeea5203df378d9b.
  • external/Vulkan-Headers: Updated the submodule commit to 952f776f6573aafbb62ea717d871cd1d6816c387.
  • external/VulkanMemoryAllocator: Updated the submodule commit to c788c52156f3ef7bc7ab769cb03c110a53ac8fcb.
  • external/backward_cpp: Updated the submodule commit to 94718085efa256fb25a311a46b5948ee0d95890a.
  • external/eigen: Updated the submodule commit to 68f4e58cfacc686583d16cff90361f0b43bc2c1b.
  • external/glfw: Updated the submodule commit to a79677378b52688ae1adaccfa25b404c3d1dcaec.
  • external/glm: Updated the submodule commit to 2d4c4b4dd31fde06cfffad7915c2b3006402322f.
  • external/googletest: Updated the submodule commit to e88cb95b92acbdce9b058dd894a68e1281b38495.
  • external/imgui: Updated the submodule commit to a7657f2ed45508bb719a8b9e2d8e7bda57eff4a0.
  • external/spdlog: Updated the submodule commit to 3335c380a08c5e0f5117a66622df6afdb3d74959.
  • external/volk: Updated the submodule commit to 58689c063427f5bad4f133625049b1a3c5dd8287.

Code improvements:

@johnnynunez johnnynunez changed the title External deps & imgui [Build] External deps & imgui Mar 5, 2025
@feisuzhu feisuzhu requested a review from bobcao3 March 6, 2025 08:06
@feisuzhu
Copy link
Contributor

feisuzhu commented Mar 6, 2025

The CI machines are currently under migration to a different DC, will trigger it once they are ready.

@johnnynunez
Copy link
Author

The CI machines are currently under migration to a different DC, will trigger it once they are ready.

thanks, also is important to migrate to newer llvm. It breaks in ubuntu 24.04 system build
ubuntu 24.04 comes with llvm18-20

@feisuzhu
Copy link
Contributor

feisuzhu commented Mar 8, 2025

/rebase

@feisuzhu
Copy link
Contributor

feisuzhu commented Mar 8, 2025

Hey, I think the CI is currently spitting legitimate errors, PTAL =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants