-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] External deps & imgui #8655
Open
johnnynunez
wants to merge
9
commits into
taichi-dev:master
Choose a base branch
from
johnnynunez:external_deps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI machines are currently under migration to a different DC, will trigger it once they are ready. |
thanks, also is important to migrate to newer llvm. It breaks in ubuntu 24.04 system build |
/rebase |
d4a02b5
to
b46b44b
Compare
Hey, I think the CI is currently spitting legitimate errors, PTAL =] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to several submodules and a minor code improvement in the
taichi
project. The most important changes include updating the submodule branches and commits, and improving the null check inIRVerifier
.Submodule updates:
.gitmodules
: Updated theexternal/eigen
submodule to use branch3.4
instead of3.3
.external/DirectX-Headers
: Updated the submodule commit to3ae9c7692ddecc9107d401fdf7999b34a8b8079b
.external/FP16
: Updated the submodule commit to98b0a46bce017382a6351a19577ec43a715b6835
.external/PicoSHA2
: Updated the submodule commit to27fcf6979298949e8a462e16d09a0351c18fcaf2
.external/SPIRV-Cross
: Updated the submodule commit to2c32b6bf86f3c4a5539aa1f0bacbd59fe61759cf
.external/SPIRV-Headers
: Updated the submodule commit to54a521dd130ae1b2f38fef79b09515702d135bdd
.external/SPIRV-Reflect
: Updated the submodule commit toc637858562fbce1b6f5dc7ca48d4e8a5bd117b70
.external/SPIRV-Tools
: Updated the submodule commit tobb86786ed9aa6576a1fb72a9eeea5203df378d9b
.external/Vulkan-Headers
: Updated the submodule commit to952f776f6573aafbb62ea717d871cd1d6816c387
.external/VulkanMemoryAllocator
: Updated the submodule commit toc788c52156f3ef7bc7ab769cb03c110a53ac8fcb
.external/backward_cpp
: Updated the submodule commit to94718085efa256fb25a311a46b5948ee0d95890a
.external/eigen
: Updated the submodule commit to68f4e58cfacc686583d16cff90361f0b43bc2c1b
.external/glfw
: Updated the submodule commit toa79677378b52688ae1adaccfa25b404c3d1dcaec
.external/glm
: Updated the submodule commit to2d4c4b4dd31fde06cfffad7915c2b3006402322f
.external/googletest
: Updated the submodule commit toe88cb95b92acbdce9b058dd894a68e1281b38495
.external/imgui
: Updated the submodule commit toa7657f2ed45508bb719a8b9e2d8e7bda57eff4a0
.external/spdlog
: Updated the submodule commit to3335c380a08c5e0f5117a66622df6afdb3d74959
.external/volk
: Updated the submodule commit to58689c063427f5bad4f133625049b1a3c5dd8287
.Code improvements:
taichi/analysis/verify.cpp
: Improved null check inIRVerifier
by using.get()
method forstmt->body
.taichi/codegen/spirv/kernel_utils.h
: Added#include "spdlog/fmt/ranges.h"
for better formatting support.