Skip to content

tailnet_settings: add fields for ACL management #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tailnet_settings: add fields for ACL management #28

wants to merge 1 commit into from

Conversation

mcoulombe
Copy link
Contributor

Updates #28349

Do not merge until https://github.com/tailscale/corp/pull/28964 is released

@review-ai-agent review.ai agent
Copy link

review-ai-agent bot commented May 23, 2025 •
edited
Loading

Pull Request Revisions

RevisionDescription
r1
Added external ACLs settings fieldsIntroduced new ACL-related fields ACLsExternallyManagedOn and ACLsExternalLink to TailnetSettings and UpdateTailnetSettingsRequest
☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

Copilot
Copilot AI reviewed May 23, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mcoulombe mcoulombe mentioned this pull request May 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@oxtoacart oxtoacart Awaiting requested review from oxtoacart

@mpminardi mpminardi Awaiting requested review from mpminardi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcoulombe