conn,device: support conn.ReceiveFunc nonzero packet offset #36
Conversation
This enables a conn.Bind to leverage wireguard-go packet memory for reading packets containing layers that wireguard-go should ignore, e.g. a VXLAN or Geneve header preceeding WireGuard. Signed-off-by: Jordan Whited <[email protected]>
| // sizes, packets, and endpoints that should be evaluated. A sizes element | ||
| // includes both the starting and ending offset for an element of packets. Some |
There was a problem hiding this comment.
❓ Confused: Is the sizes element defined as [start, end)? It would be nice if the documentation were more explicit about ranges.
❓ Confused: Is this the name sizes still the right name for this, now that it is some kind of range or interval? Granted, I cannot come up with a better name.
| sizes []int, | ||
| sizes [][2]int, |
There was a problem hiding this comment.
❓ Confused: Is this tuple always going to be a range? Would it be more clear as a type size struct{ start, end int } or is that worse somehow?
There was a problem hiding this comment.
LGTM. Reflecting some discussion off-github: we're balancing extending the functionality of this API for a pressing need, vs. doing a larger scale refactor to improve the packet wrangling API as a whole.
The latter is tempting, but is likely to spiral into a large change as it bubbles through more of the API. We'd rather tackle a broader redesign separately (and we're gearing up to, available bandwidth notwithstanding), rather than end up pulling refactors into this targeted feature change.
| @@ -268,8 +268,8 @@ func (s *StdNetBind) receiveIP( | |||
| } | |||
| for i := 0; i < numMsgs; i++ { | |||
| msg := &(*msgs)[i] | |||
| sizes[i] = msg.N | |||
| if sizes[i] == 0 { | |||
| sizes[i][0], sizes[i][1] = 0, msg.N | |||
There was a problem hiding this comment.
minor suggestion, optional: move the continue branch below further up, and make the condition look at msg.N instead of the sizes array? As written here it took me a beat to translate the branch condition to "oh, skip empty messages".
This enables a conn.Bind to leverage wireguard-go packet memory for reading packets containing layers that wireguard-go should ignore, e.g. a VXLAN or Geneve header preceeding WireGuard.