Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reminder & alarm code #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stesie
Copy link
Contributor

@stesie stesie commented Oct 20, 2012

Hi again,

this patch

  • refactors the words to timestamp conversion code of the reminder & alarm setting code. The same piece of code was present three times in very similar versions
  • uses alarmd instead of at to do the notification (which wasn't listed as a dependency anyways)
  • make sure the actual message is passed to espeak
  • alarm is set even if time and message are in the first piece of input
  • refactors resetting of next_func to before calling it. This way not every next_func needs to reset next_func individually

cheers,
stesie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant