Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require nbconvert #30

Merged
merged 2 commits into from
May 15, 2024
Merged

Don't require nbconvert #30

merged 2 commits into from
May 15, 2024

Conversation

takluyver
Copy link
Owner

Nbconvert is only needed for the execute=True option, which was deprecated in version 0.6. Loading nbconvert may be slow, so we don't want to do it when it's not needed.

A future version of nbparameterise will likely remove the execute= option entirely. Anyone using it should make a separate call to a package like nbclient or princess instead.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e0466fc) 93.33% compared to head (3adb3fc) 92.82%.

Files Patch % Lines
nbparameterise/code.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   93.33%   92.82%   -0.52%     
==========================================
  Files           3        3              
  Lines         195      195              
==========================================
- Hits          182      181       -1     
- Misses         13       14       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takluyver takluyver merged commit 0eee210 into master May 15, 2024
8 of 10 checks passed
@takluyver takluyver deleted the no-require-nbconvert branch May 15, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant