Add truncate statement support #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleggator
force-pushed
the
release-42.0.0-truncate
branch
3 times, most recently
from
7ea6796 to
ca47b51
Compare
oleggator
force-pushed
the
release-42.0.0-truncate
branch
from
ca47b51 to
177048f
Compare
oleggator
force-pushed
the
release-42.0.0-truncate
branch
from
177048f to
4fb5e19
Compare
oleggator
force-pushed
the
release-42.0.0-truncate
branch
from
4fb5e19 to
a31a6e1
Compare
askalt
reviewed
Jul 9, 2025
| @@ -1228,6 +1228,10 @@ impl DefaultPhysicalPlanner { | |||
| "Unsupported logical plan: Analyze must be root of the plan" | |||
| ) | |||
| } | |||
| LogicalPlan::Truncate(_) => { | |||
There was a problem hiding this comment.
Why is it required to extend LogicalPlan enum? Isn't LogicalPlan::Extension not enough for our purposes?
There was a problem hiding this comment.
I haven't considered this option. It might suit this case better. That way, we can move all the additional logic inside TCS.
There was a problem hiding this comment.
Yes, here an example of such approach:
Own extensions for prepare, execute, and deallocate (prepared statements stuff).
And physical planning for extensions in the custom planner:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TRUNCATE operation to LogicalPLan enum.