Skip to content

Moves description of the on_event callback to a separate subsection #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 60 additions & 30 deletions doc/platform/app/app_roles.rst
Original file line number Diff line number Diff line change
Expand Up @@ -67,39 +67,16 @@ Overview
A custom application role is an object which implements custom functions or logic adding to Tarantool's built-in roles and roles provided by third-party Lua modules.
For example, a logging role can be created to add logging functionality on top of the built-in one.

Since version :doc:`3.4.0 </release/3.4.0>`, you can define an ``on_event`` callback for custom roles. The ``on_event`` callback is called
every time a ``box.status`` system event is broadcasted.
If multiple custom roles have the ``on_event`` callback defined, these callbacks are called one after another in the order
defined by roles dependencies.

The ``on_event`` callback returns 3 arguments, when it is called:

- ``config``, which contains the configuration of the role;

- ``key``, which reflects the trigger event and is set to:

- ``config.apply`` if the callback was triggered by a configuration update;

- ``box.status`` if it was triggered by the ``box.status`` system event.
- ``value``, which shows and logs the information about the instance status as in the trigger ``box.status`` system event.
If the callback is triggered by a configuration update, the ``value`` shows the information of the most recent ``box.status`` system event.

.. NOTE::

- All ``on_event`` callbacks with the ``config.apply`` key are executed as a part of the configuration process.
Process statuses ``ready`` or ``check_warnings`` are reached only after all such ``on_event`` callbacks are done.

- All ``on_event`` callbacks are executed inside of a ``pcall``. If an error is raised for a callback, it is logged
with the ``error`` level and the series execution continues.

Creating a custom role includes the following steps:

#. (Optional) Define the role configuration schema.
#. Define a function that validates a role configuration.
#. Define a function that applies a validated configuration.
#. Define a function that stops a role.
#. (Optional) Define roles from which this custom role depends on.
#. (Optional) Define the ``on_event`` callback function.
#. (Optional) Define the :ref:`role configuration schema <roles_create_custom_role_schema>`.
#. Define a function that :ref:`validates a role configuration <roles_create_custom_role_validate>`.
#. Define a function that :ref:`applies a validated configuration <roles_create_custom_role_apply>`.
#. Define a function that :ref:`stops a role <roles_create_custom_role_stop>`.
#. (Optional) Define roles from which this custom role :ref:`depends on <roles_create_custom_role_dependencies>`.
#. (Optional) Define the ``on_event`` :ref:`callback function <roles_create_custom_role_on_event_callback>`.

As a result, a role module should return an object that has corresponding functions and fields specified:

Expand Down Expand Up @@ -130,7 +107,7 @@ You can omit the optional steps and get a simple role as in the example below.
stop = function() -- ... -- end,
}

You can modify a role, for example, by adding dependencies or specifying the on_event callback.
You can modify a role, for example, by adding dependencies or specifying the ``on_event`` callback.
If you modify a role, you need to restart the Tarantool instance with the role in order to apply the changes.

.. NOTE::
Expand Down Expand Up @@ -238,7 +215,60 @@ This means that all the dependencies of a role should be defined in the ``roles`

You can find the full example here: `application_role_cfg <https://github.com/tarantool/doc/tree/latest/doc/code_snippets/snippets/config/instances.enabled/application_role_cfg>`_.

.. _roles_create_custom_role_on_event_callback:

On_event callback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, there is the 'Specifics of creating spaces' below and it is written before the on_event callback was implemented. We possibly should recommend to use the on_event callback for this scenario, because it should be simpler. Reach me or @grafin for examples if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in #5246

~~~~~~~~~~~~~~~~~

Since version :doc:`3.4.0 </release/3.4.0>`, you can define the ``on_event`` callback for custom roles. The ``on_event`` callback is called
every time a ``box.status`` system event is broadcasted.
If multiple custom roles have the ``on_event`` callback defined, these callbacks are called one after another in the order
defined by roles dependencies.

The ``on_event`` callback returns 3 arguments, when it is called:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, it accepts three arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in #5246


- ``config``, which contains the configuration of the role;

- ``key``, which reflects the trigger event and is set to:

- ``config.apply`` if the callback was triggered by a configuration update;

- ``box.status`` if it was triggered by the ``box.status`` system event.
- ``value``, which shows and logs the information about the instance status as in the trigger ``box.status`` system event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how it logs anything.

Copy link
Contributor Author

@AArdeev AArdeev Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in #5246

If the callback is triggered by a configuration update, the ``value`` shows the information of the most recent ``box.status`` system event.

.. NOTE::

- All ``on_event`` callbacks with the ``config.apply`` key are executed as a part of the configuration process.
Process statuses ``ready`` or ``check_warnings`` are reached only after all such ``on_event`` callbacks are done.

- All ``on_event`` callbacks are executed inside of a ``pcall``. If an error is raised for a callback, it is logged
with the ``error`` level and the series execution continues.

.. code-block:: lua

return {
validate = function() end,
apply = function()
_G.foo = 0
end,
stop = function()
_G.foo = -1
_G.bar = nil
end,
on_event = function(config, key, value)
assert(_G.foo >= 0)
assert(config == 12345)
if(_G.foo == 0) then
assert(key == 'config.apply')
else
assert(key == 'box.status')
end
_G.is_ro = value.is_ro
_G.foo = _G.foo + 1
_G.bar = config
end,
}
Comment on lines +250 to +271
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the idea behind all this arithmetic?

Here we demonstrate how on_event works, right? So, maybe, an example with creating a space schema or writing something into a space would suit better (we need to react to transition from RO to RW)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in #5246


.. _roles_create_custom_role_init:

Expand Down