TNTP-3334: IPROTO_IS_SYNC support for begin/commit #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-is-sync-support
branch
2 times, most recently
from
ee93a3e to
513ae48
Compare
NB: all deleted tests were checking that functions passed from constructor object to fillXXX function were passed in right order, so removing them is not a problem
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-is-sync-support
branch
3 times, most recently
from
5f1d4dc to
4357337
Compare
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-is-sync-support
branch
from
4357337 to
c74d03f
Compare
-> |
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-is-sync-support
branch
2 times, most recently
from
5bb8713 to
8892063
Compare
Part of #TNTP-3334 Closes #366
bigbes
force-pushed
the
bigbes/TNTP-3334-iproto-is-sync-support
branch
from
8892063 to
f8f4d2d
Compare
oleg-jukovec
requested changes
Jul 1, 2025
| conn := exampleConnect(dialer, opts) | ||
| defer conn.Close() | ||
|
|
||
| // Tarantool supports IS_SYNC flag for BeginRequest since version 3.1.0 |
There was a problem hiding this comment.
A comment should end with a dot.
Suggested change
| // Tarantool supports IS_SYNC flag for BeginRequest since version 3.1.0 | |
| // Tarantool supports IS_SYNC flag for BeginRequest since version 3.1.0. |
| conn := exampleConnect(dialer, opts) | ||
| defer conn.Close() | ||
|
|
||
| // Tarantool supports IS_SYNC flag for CommitRequest since version 3.1.0q |
There was a problem hiding this comment.
Suggested change
| // Tarantool supports IS_SYNC flag for CommitRequest since version 3.1.0q | |
| // Tarantool supports IS_SYNC flag for CommitRequest since version 3.1.0. |
| return | ||
| } | ||
|
|
||
| // Begin transaction |
There was a problem hiding this comment.
Suggested change
| // Begin transaction | |
| // Begin transaction. |
| return | ||
| } | ||
|
|
||
| // Insert in stream |
There was a problem hiding this comment.
Suggested change
| // Insert in stream | |
| // Insert in stream. |
| return | ||
| } | ||
|
|
||
| // Commit transaction in sync mode |
There was a problem hiding this comment.
Suggested change
| // Commit transaction in sync mode | |
| // Commit transaction in sync mode. |
| baseRequest | ||
| txnIsolation TxnIsolationLevel | ||
| timeout time.Duration | ||
| isSync *bool |
There was a problem hiding this comment.
Let's avoud a pointer here.
Suggested change
| isSync *bool | |
| isSync bool | |
| isSyncExist bool |
| @@ -137,6 +152,8 @@ func (req *BeginRequest) Context(ctx context.Context) *BeginRequest { | |||
| // Commit request can not be processed out of stream. | |||
| type CommitRequest struct { | |||
| baseRequest | |||
|
|
|||
| isSync *bool | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
BeginRequest.IsSync(bool)andCommitRequest.IsSync(bool).Refactor
Bodymethods of all Requests, do not usefillXXXfunctions.Part of TNTP-3334
Closes #366