Skip to content

Fix failing lint #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,8 @@ good-names=i,j,k,ex,Run,_,ok,t,tz
[FORMAT]
# Allow links in docstings, allow tables
ignore-long-lines=^(?:\s*(# )?(?:\.\.\s.+?:)?\s*<?https?://\S+>?)|(\s\+.+\+)|(\s\|.+\|)$

[MESSAGES CONTROL]
# Ignore unknown options to support per-entity ignores for newest warnings/errors
# which are not supported for older versions.
disable=unknown-option-value
12 changes: 7 additions & 5 deletions requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
git+https://github.com/baztian/dbapi-compliance.git@ea7cb1b4#egg=dbapi-compliance
pyyaml==6.0
importlib-metadata >= 1.0 ; python_version < '3.8'
pylint ~= 3.0 ; python_version >= '3.8'
pylint ~= 2.13 ; python_version < '3.8'
flake8 ~= 6.1 ; python_version >= '3.8'
flake8 ~= 5.0 ; python_version < '3.8'
codespell ~= 2.2
pylint == 3.3.0 ; python_version >= '3.9'
pylint == 3.2.7 ; python_version == '3.8'
pylint == 2.17.7 ; python_version == '3.7'
flake8 == 6.1.0 ; python_version >= '3.8'
flake8 == 5.0.4 ; python_version < '3.8'
codespell == 2.3.0 ; python_version >= '3.8'
codespell == 2.2.5 ; python_version < '3.8'
2 changes: 1 addition & 1 deletion tarantool/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""
This package provides API for interaction with a Tarantool server.
"""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments

from tarantool.connection import Connection
from tarantool.mesh_connection import MeshConnection
Expand Down
2 changes: 1 addition & 1 deletion tarantool/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ def __init__(self,
.. _mp_bin: https://github.com/msgpack/msgpack/blob/master/spec.md#bin-format-family
.. _mp_array: https://github.com/msgpack/msgpack/blob/master/spec.md#array-format-family
"""
# pylint: disable=too-many-arguments,too-many-locals,too-many-statements
# pylint: disable=too-many-arguments,too-many-locals,too-many-statements,too-many-positional-arguments

if host is None and port is None and socket_fd is None:
raise ConfigurationError("need to specify host/port, "
Expand Down
2 changes: 1 addition & 1 deletion tarantool/connection_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ def __init__(self,
.. _box.info.status:
.. _box.info: https://www.tarantool.io/en/doc/latest/reference/reference_lua/box_info/
"""
# pylint: disable=too-many-arguments,too-many-locals
# pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments

if not isinstance(addrs, list) or len(addrs) == 0:
raise ConfigurationError("addrs must be non-empty list")
Expand Down
2 changes: 1 addition & 1 deletion tarantool/mesh_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ def __init__(self,
:class:`~tarantool.Connection` exceptions,
:class:`~tarantool.MeshConnection.connect` exceptions
"""
# pylint: disable=too-many-arguments,too-many-locals
# pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments

if addrs is None:
addrs = []
Expand Down
8 changes: 4 additions & 4 deletions tarantool/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def __init__(self, conn, salt, user, password, auth_type=AUTH_TYPE_CHAP_SHA1):
:param auth_type: Refer to :paramref:`~tarantool.Connection.auth_type`.
:type auth_type: :obj:`str`, optional
"""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments

super().__init__(conn)

Expand Down Expand Up @@ -405,7 +405,7 @@ def __init__(self, conn, space_no, index_no, key, offset, limit, iterator):

:raise: :exc:`~AssertionError`
"""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments

super().__init__(conn)
request_body = self._dumps({IPROTO_SPACE_ID: space_no,
Expand Down Expand Up @@ -446,7 +446,7 @@ def __init__(self, conn, space_no, index_no, key, op_list):

:raise: :exc:`~AssertionError`
"""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments

super().__init__(conn)

Expand Down Expand Up @@ -569,7 +569,7 @@ def __init__(self, conn, space_no, index_no, tuple_value, op_list):

:raise: :exc:`~AssertionError`
"""
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments

super().__init__(conn)

Expand Down
2 changes: 1 addition & 1 deletion test/suites/lib/tarantool_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class TarantoolServer():
"""
Class to start up a new Tarantool server.
"""
# pylint: disable=too-many-instance-attributes,too-many-arguments,duplicate-code
# pylint: disable=too-many-instance-attributes,too-many-arguments,duplicate-code,too-many-positional-arguments

default_tarantool = {
"bin": "tarantool",
Expand Down
2 changes: 1 addition & 1 deletion test/suites/test_ssl.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def is_test_ssl():


class SslTestCase:
# pylint: disable=too-few-public-methods,too-many-instance-attributes,too-many-arguments
# pylint: disable=too-few-public-methods,too-many-instance-attributes,too-many-arguments,too-many-positional-arguments

def __init__(self,
name="",
Expand Down
Loading