Add individual intensities #212
Conversation
… legendre polynomial
jvshields
force-pushed
the
add_individual_intensities
branch
from
704255f to
e894d63
Compare
|
The new and modified functions could really use tests |
|
Add a plot to this PR to show it's working |
|
I want to change this PR to make the simulation only keep track of each individual ray when you request the simulation to return the radiation field. As is, we end up using a ton of memory on all of the rays. Edit: Did this |
| ) | ||
|
|
||
| # This was our original theta sampling method | ||
| # dtheta = (np.pi / 2) / num_of_thetas # Korg uses Gauss-Legendre quadrature here |
There was a problem hiding this comment.
Does this need to be kept? If so I would put it in a test for comparison purposes.
|
Need to update the regression data |
| @@ -253,24 +343,36 @@ def single_theta_trace( | |||
| / (taus[gap_indices] + taus[gap_indices + 1]) | |||
| ) | |||
|
|
|||
| if inward_rays: | |||
| pass | |||
There was a problem hiding this comment.
Something worth to check -- the inward_rays condition seems like doing something slightly different in the single_theta_trace_parallel function, should these two function be computing the same thing?
| * (taus[gap_index, nu_index] / taus[gap_index + 1, nu_index]) | ||
| - (source[gap_index + 1, nu_index] - source[gap_index, nu_index]) | ||
| * (taus[gap_index + 1, nu_index] / taus[gap_index, nu_index]) | ||
| if taus[gap_index, nu_index] == 0: |
There was a problem hiding this comment.
Is this part of the calculations needed for the case inward_rays = True as well or should it be in the else condition?
This PR implements spherical geometry in to STARDIS, and also allows for individual rays to be kept track of and returned at the end of the simulation. This allows the user to look at the different parts of the stellar disk (center-limb variation in inensity).