Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the faulty dataset links in the codebase #239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sonu0305
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

Updated the faulty links with the working links in two files,
docs/Custom_atomic_data/Custom_atomic_data.ipynb and .github/workflows/benchmarks.yml.

Closes #238

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Jan 12, 2025

Hi @atharva-2001 @andrewfullard @jvshields @wkerzendorf ,
Could you please review when you have a chance, Thank You.

@jvshields jvshields closed this Jan 13, 2025
@jvshields jvshields reopened this Jan 13, 2025
@jvshields
Copy link
Contributor

Woops, meant to close a different pr. Reopened this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty data download links in the codebase
2 participants