Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimators restructure cleanup #2512

Merged

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🪲 bugfix | 🚀 feature | 🎢 infrastructure

Cleanup of #2500 including all of its change, plus tests pass (except for 2 tests with segmentation faults when run in serial with model tests)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (17c5da9) 68.63% compared to head (34da801) 68.13%.

Files Patch % Lines
...is/montecarlo/estimators/radfield_mc_estimators.py 47.76% 35 Missing ⚠️
...ecarlo/estimators/continuum_radfield_properties.py 48.97% 25 Missing ⚠️
...estimators/tests/test_continuum_property_solver.py 33.33% 16 Missing ⚠️
...ontecarlo/montecarlo_numba/tests/test_continuum.py 33.33% 12 Missing ⚠️
...lasma/properties/util/integrate_array_by_blocks.py 0.00% 12 Missing ⚠️
tardis/montecarlo/estimators/util.py 41.17% 10 Missing ⚠️
tardis/montecarlo/tests/test_montecarlo.py 66.66% 2 Missing ⚠️
tardis/io/atom_data/base.py 96.29% 1 Missing ⚠️
tardis/model/radiation_field_state.py 80.00% 1 Missing ⚠️
tardis/plasma/properties/atomic.py 88.88% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2512      +/-   ##
==========================================
- Coverage   68.63%   68.13%   -0.50%     
==========================================
  Files         159      166       +7     
  Lines       13749    13961     +212     
==========================================
+ Hits         9437     9513      +76     
- Misses       4312     4448     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard merged commit 234c586 into tardis-sn:master Feb 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants