Skip to content

fix: use importlib.import_module instead of __import__ #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use importlib.import_module instead of __import__ #745

wants to merge 1 commit into from

Conversation

bhearsum
Copy link
Contributor

import_module is newer, and provides a couple of advantages over a bare __import__:

The import_module() function acts as a simplifying wrapper around importlib.import(). This means all semantics of the function are derived from importlib.import(). The most important difference between these two functions is that import_module() returns the specified package or module (e.g. pkg.mod), while import() returns the top-level package or module (e.g. pkg).

It's unclear if this will actually fix any problems in the real world, but there's no recent to use __import__ at this point AFAICT.

@bhearsum bhearsum requested a review from a team as a code owner August 14, 2025 15:43
@bhearsum
fix: use importlib.import_module instead of __import__
1d1eb85 
`import_module` is newer, and provides a couple of advantages over a bare `__import__`:
> The import_module() function acts as a simplifying wrapper around importlib.__import__(). This means all semantics of the function are derived from importlib.__import__(). The most important difference between these two functions is that import_module() returns the specified package or module (e.g. pkg.mod), while __import__() returns the top-level package or module (e.g. pkg).

It's unclear if this will actually fix any problems in the real world, but there's no recent to use `__import__` at this point AFAICT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eijebong Eijebong Eijebong approved these changes

@abhishekmadan30 abhishekmadan30 Awaiting requested review from abhishekmadan30 abhishekmadan30 is a code owner automatically assigned from taskcluster/releng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhearsum @Eijebong