Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip gas estimation if already present (ethereum) #1081

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

korkoshko
Copy link

@korkoshko korkoshko commented Mar 20, 2024

Description

We don't need call estimateGas if the gas property already present in the serialized transaction.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@korkoshko
Copy link
Author

@Hathoriel could you please review this?

@Hathoriel
Copy link
Member

Hello @korkoshko
Thank you for your PR.
It looks perfect, but can you please upgrade the package.json version?
After you do it, I will approve and merge this pull request.
Thank you

@korkoshko
Copy link
Author

@Hathoriel Done. Thanks!

@Hathoriel Hathoriel merged commit 9ed1d59 into tatumio:v1 Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants