Document merge for rosters #865
Conversation
all_document_merge_rosters.class.php Create temporary document name Allow for 'Dump' option roster_view.class.php Pass more data, especially in relation to the services views/view_7_rosters__1_display_roster_assignments.class.php Add in the dialog like the other two
|
I'm confused about what this actually does. |
|
(I've seen the sign-in-sheet template, but I'm confused as to how it relates to a multi-column roster) |
|
I replied from the email with attachments? Got to go to a meeting now. |
|
Email attachments might not make it through to github. Might need to try uploading direct in the web UI. |
|
For youth ministries, sign-in/out is a requirement for 'child safe' so I produce a sheet with the names of everyone rostered on that day to sign. |
|
My comments are not coming through email. Maybe it's because I send using a different email address! |
| @@ -422,8 +422,8 @@ public function printCSV($start_date=NULL, $end_date=NULL, $return=FALSE) | |||
|
|
|||
| $to_print = Array(); | |||
| foreach ($services as $id => $service_details) { | |||
| $to_print[$service_details['date']]['service'][$service_details['congregationid']] = $service_details; | |||
There was a problem hiding this comment.
There's a problem here. A roster view may include details of several services on the same date (for different congregations). The array needs to be indexed by congregationid or they will overwrite each other.
There was a problem hiding this comment.
Trying to wrap my head around this.
I've experimented with this on my system and it works with two congregations with services on the same days.
I think it works because getCongregations looks at the members and all the members in the service belong to the same congregation..
There was a problem hiding this comment.
Ah yes, I think I misread this line - sorry. It's already indexed by congregationid.
There was a problem hiding this comment.
I've changed the order of the indexing and made service details available from all included congregations now.
The code in this PR was pretty stale so I have created a replacement PR #932 after rebasing my fork against your latest version.
| @@ -460,6 +460,34 @@ public function printCSV($start_date=NULL, $end_date=NULL, $return=FALSE) | |||
|
|
|||
| foreach ($to_print as $date => $ddetail) { | |||
There was a problem hiding this comment.
likewise here, it's assuming that there is one service per date, but that's not the case
|
I haven't really been using congregations except to separate out rosters for week day ministries, so not surprising I missed that. |
|
The purpose of getting the service details is as a nice to have feature to allow service details to be shown on the roster. |
Replaces PR tbar0970#865 Now copes with multiple congregations I had to strip out the SizeDetector test on my system as it caused the option to be omitted.
all_document_merge_rosters.class.php
Create temporary document name
Allow for 'Dump' option
roster_view.class.php
Pass more data, especially in relation to the services views/view_7_rosters__1_display_roster_assignments.class.php Add in the dialog like the other two