Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underlines from action links #954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jefft
Copy link
Contributor

@jefft jefft commented Sep 7, 2023

I think this UI tweak, removing underline links, makes the UI a bit cleaner. WDYT?

Before/after screenshots:

Dashboard

Before

image

After

image

Person action links

Before

image

After

image

Groups

Before

image

After

image

@tbar0970
Copy link
Owner

tbar0970 commented Sep 8, 2023

Hmm, I get the thinking, but I'm not sure about removing every underline from every link. I'll have a play with it.

@tbar0970
Copy link
Owner

tbar0970 commented May 3, 2024

I do like removing underlines from the links within headings, as in your first screenshot.

And I can see how when there is an icon (eg spanner), it's obvious that the link is a clickable action, so underline is not needed for that.

I notice there are now some options we could play with to make the underlines less pronounced:
text-decoration-color: #bbb
or text-decoration-style: dotted

Another option, on desktop, is to only show the underline on hover.

I've just realised Jethro is a bit inconsistent with lists of objects. In the group list shown in your screenshots, all the group names are (underlined) links to view the group. But elsewhere (eg Persons > list all) we have non-linked names, with a "view" link on the side, which makes for less underlining overall. There is some JS magic so that in such a situation you can still click anywhere in the table row to view the object (but this is missing for the notes list!). We should probably be more consistent with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants