Editorial: Explicitly track async evaluation order of pending modules #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
changed the title
nicolo-ribaudo
force-pushed
the
async-evaluation-order
branch
2 times, most recently
from
d600852 to
f96a304
Compare
syg
reviewed
Jun 21, 2024
nicolo-ribaudo
force-pushed
the
async-evaluation-order
branch
2 times, most recently
from
4cdd981 to
b1c782e
Compare
|
PR updated, sorry I forgot about this. For #3353 (comment), I pushed it in a second commit to make it easier to review where I'm using |
The execution order of modules that were waiting on a given async module was based on the order in which their [[AsyncEvaluation]] field was set to *true*. This PR replaces the [[AsyncEvaluation]] boolean with an actual number that keeps track of ordering in each agent. It also adds a note on when it's safe to reset this order to 0, since: - implementations might want to prevent this number from overflowing, and V8 currently has a bug that resets the number to 0 too early - figuring out when it's safe to reset the number might not be trivial, given the complexity of the module algorithms.
nicolo-ribaudo
force-pushed
the
async-evaluation-order
branch
from
d5527c1 to
0789693
Compare
bakkot
reviewed
Feb 21, 2025
bakkot
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
LGTM with my comment. This is so much nicer, thanks.
Don't forget to update https://tc39.es/proposal-defer-import-eval/#sec-example-cyclic-module-record-graphs-deferred-imports after this lands.
jmdyck
requested changes
Feb 22, 2025
| </td> | ||
| <td> | ||
| a Boolean | ||
| ~unset~, an integer, or ~done~ |
There was a problem hiding this comment.
Suggested change
| ~unset~, an integer, or ~done~ | |
| an integer, ~unset~, or ~done~ |
(editorial convention says to put types before constants)
There was a problem hiding this comment.
I actually did this on purpose, since the value "evolves" from unset, to an integer, to done.
React with 👎 if you think I should still change it :)
| @@ -27144,7 +27165,8 @@ <h1> | |||
| 1. Let _requiredModule_ be the last element of _stack_. | |||
| 1. Remove the last element of _stack_. | |||
| 1. Assert: _requiredModule_ is a Cyclic Module Record. | |||
| 1. If _requiredModule_.[[AsyncEvaluation]] is *false*, set _requiredModule_.[[Status]] to ~evaluated~. | |||
| 1. Assert: _requiredModule_.[[AsyncEvaluationOrder]] is either ~unset~ or an integer. | |||
There was a problem hiding this comment.
Suggested change
| 1. Assert: _requiredModule_.[[AsyncEvaluationOrder]] is either ~unset~ or an integer. | |
| 1. Assert: _requiredModule_.[[AsyncEvaluationOrder]] is either an integer or ~unset~. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution order of modules that were waiting on a given async module was based on the order in which their [[AsyncEvaluation]] field was set to true.
This PR replaces the [[AsyncEvaluation]] boolean with an actual number that keeps track of ordering in each agent. It also adds a note on when it's safe to reset this order to 0, since:
You can verify the numbers in the updated tables for the example using https://nicolo-ribaudo.github.io/es-module-evaluation/.
Fixes #3289