Editorial: Document initial internal slot values at their point of creation #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to stop doing this #3399 though I guess I'm fine with adding a note for now. |
|
I'm very much in favor of fixing #3399, but this is an easy win in the interim. |
michaelficarra
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
I guess this is fine, we'll just have to remove it with #3399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object Internal Methods and Internal Slots defines the initial value of an internal slot to be undefined, but without a reference to that in MakeBasicObject, it can be difficult to track branding/externally-oriented slots such as Error [[ErrorData]], AllocateArrayBuffer [[ArrayBufferDetachKey]], and ECMA-402 [[Initialized$TypeName]] slots.
This PR adds a note to make that behavior more obvious.