Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jsdom and lowcase element selectors #620

Merged
merged 1 commit into from
Nov 6, 2024
Merged

bump jsdom and lowcase element selectors #620

merged 1 commit into from
Nov 6, 2024

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Sep 29, 2024

jsdom has finally updated its transitive dependency which was printing a deprecation warning, so bump it to silence the warning here.

None of the breaking changes should be relevant to us, but there's a bug where CSS selectors are incorrectly case-sensitive wrt element names, so we need to change a couple uppercase ones here,

@bakkot bakkot merged commit 44bb83e into main Nov 6, 2024
2 checks passed
@bakkot bakkot deleted the bump-jsdom branch November 6, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants