Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in discussions.md #61

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix typo in discussions.md #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/other_languages/discussions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ In both cases - **this means that RegExp.escape can't guarantee the length of th

First of all - PHP is underspecified but the docs indicate that `. \ + * ? [ ^ ] $ ( ) { } = ! < > | : -` are escaped.

In addition to the current proposal, they esacpe `! < > : - =` which are context-sentitve parts. That is, they escape characters that might make parts of lookaheads, lookbehinds and ranges.
In addition to the current proposal, they escape `! < > : - =` which are context-sentitve parts. That is, they escape characters that might make parts of lookaheads, lookbehinds and ranges.

Out of these things, `! : -` seems relevant for the ES syntax and should be independently considered. There is current discussion about context sensitive identifiers in https://github.com/benjamingr/RegExp.escape/issues/17 . They also provide a flag for escaping `/` which we find a poor design choice.

Expand Down