Upgrade fastapi to 0.114.1 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rralcala
force-pushed
the
master
branch
4 times, most recently
from
9f1771e
to
39572bf
Compare
tchx84
requested changes
Sep 15, 2024
README.md
Outdated
| @@ -4,6 +4,8 @@ LINKA is an open source service to record air quality data from community sensor | |||
|
|
|||
| ## Install | |||
|
|
|||
| Python 3.12 is not yet supported | |||
There was a problem hiding this comment.
Let's move this as a proper note at the bottom of the subsection, like
Note
Python 3.12 is not yet supported.
> [!NOTE]
> Python 3.12 is not yet supported.
|
The answer to most of the comments is: Fastapi pulls a stricter version of pydantic, so issues that weren't raised previously are being raised now. |
Which triggers an upgrade to pydantic, and a bunch of validation failures
tchx84
requested changes
Sep 17, 2024
tchx84
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also resolves some deprecation warnings from sqlalchemy and fix a test.