Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#795) 쓸모없는 조건문 제거 #796

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

ilyoil2
Copy link
Member

@ilyoil2 ilyoil2 commented Nov 5, 2024

작업 내용 설명

사용하지 않는 조건문 삭제했습니다

주요 변경 사항

결과물

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@ilyoil2 ilyoil2 added the refactor 코드 리팩토링 할 경우 label Nov 5, 2024
@ilyoil2 ilyoil2 self-assigned this Nov 5, 2024
@ilyoil2 ilyoil2 linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.34%. Comparing base (dac583a) to head (894b6ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #796   +/-   ##
=========================================
  Coverage       3.34%   3.34%           
  Complexity        90      90           
=========================================
  Files            655     655           
  Lines           9263    9260    -3     
  Branches         216     216           
=========================================
  Hits             310     310           
+ Misses          8943    8940    -3     
  Partials          10      10           
Files with missing lines Coverage Δ
...ms/domain/outing/service/CheckOutingServiceImpl.kt 0.00% <ø> (ø)
...ting/usecase/GetCurrentOutingApplicationUseCase.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac583a...894b6ff. Read the comment docs.

@ilyoil2 ilyoil2 merged commit 71272b2 into develop Nov 25, 2024
2 checks passed
@ilyoil2 ilyoil2 deleted the ref/795-delete-useless-validation branch November 25, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

쓸모없는 조건문 삭제
2 participants