-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] :: 잔류 신청 퍼블리싱 #105
The head ref may contain hidden characters: "feature/104-feat-\uC794\uB958-\uC2E0\uCCAD-\uD37C\uBE14\uB9AC\uC2F1"
[feat] :: 잔류 신청 퍼블리싱 #105
Changes from 10 commits
df33009
cfe8294
31530df
50c1472
6aac74b
32faed4
61d1d95
22773b3
bcc5213
9a2d17f
8992be2
e2fb8e6
ef0d218
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -7,10 +7,16 @@ import androidx.navigation.compose.composable | |||||||||||||||||||||
const val NAVIGATION_ROOT = "root" | ||||||||||||||||||||||
|
||||||||||||||||||||||
fun NavGraphBuilder.root( | ||||||||||||||||||||||
onNavigateRemainApplication: () -> Unit, | ||||||||||||||||||||||
onNavigateOutingApplication: () -> Unit, | ||||||||||||||||||||||
onNoticeDetailsClick: (Long) -> Unit, | ||||||||||||||||||||||
) { | ||||||||||||||||||||||
composable(NAVIGATION_ROOT) { | ||||||||||||||||||||||
Root(onNoticeDetailClick = onNoticeDetailsClick) | ||||||||||||||||||||||
Root( | ||||||||||||||||||||||
onNavigateRemainApplication = onNavigateRemainApplication, | ||||||||||||||||||||||
onNavigateOutingApplication = onNavigateOutingApplication, | ||||||||||||||||||||||
onNoticeDetailClick = onNoticeDetailsClick | ||||||||||||||||||||||
) | ||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 트레일링 콤마를 추가해주세요 CI 파이프라인 경고에 따라 마지막 파라미터 뒤에 트레일링 콤마를 추가해야 합니다. Root(
onNavigateRemainApplication = onNavigateRemainApplication,
onNavigateOutingApplication = onNavigateOutingApplication,
- onNoticeDetailClick = onNoticeDetailsClick
+ onNoticeDetailClick = onNoticeDetailsClick,
) 📝 Committable suggestion
Suggested change
🧰 Tools🪛 GitHub Actions: Kotlin Multiplatform CI[warning] 18-18: Missing trailing comma before ')' |
||||||||||||||||||||||
} | ||||||||||||||||||||||
} | ||||||||||||||||||||||
|
||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package team.aliens.dms.kmp.core.designsystem.float | ||
|
||
import androidx.compose.foundation.background | ||
import androidx.compose.foundation.layout.Arrangement | ||
import androidx.compose.foundation.layout.Row | ||
import androidx.compose.foundation.layout.fillMaxWidth | ||
import androidx.compose.foundation.layout.padding | ||
import androidx.compose.foundation.shape.RoundedCornerShape | ||
import androidx.compose.material3.Icon | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Alignment | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.unit.dp | ||
import org.jetbrains.compose.resources.DrawableResource | ||
import org.jetbrains.compose.resources.painterResource | ||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsIcon | ||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsTheme | ||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsTypography | ||
import team.aliens.dms.kmp.core.designsystem.text.DmsText | ||
|
||
@Composable | ||
fun DmsFloatingNotice( | ||
modifier: Modifier = Modifier, | ||
text: String, | ||
iconResource: DrawableResource = DmsIcon.Notification, | ||
) { | ||
Row( | ||
modifier = modifier | ||
.fillMaxWidth() | ||
.background( | ||
color = DmsTheme.colors.primary, | ||
shape = RoundedCornerShape(30.dp), | ||
).padding( | ||
horizontal = 22.dp, | ||
vertical = 12.dp, | ||
), | ||
verticalAlignment = Alignment.CenterVertically, | ||
horizontalArrangement = Arrangement.spacedBy(14.dp), | ||
) { | ||
Icon( | ||
painter = painterResource(iconResource), | ||
contentDescription = null, | ||
) | ||
DmsText( | ||
text = text, | ||
style = DmsTypography.Body3, | ||
color = DmsTheme.colors.onBackground, | ||
) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
package team.aliens.dms.kmp.core.designsystem.tag | ||
|
||
import androidx.compose.foundation.BorderStroke | ||
import androidx.compose.foundation.layout.PaddingValues | ||
import androidx.compose.foundation.layout.padding | ||
import androidx.compose.foundation.shape.RoundedCornerShape | ||
import androidx.compose.material.Surface | ||
import androidx.compose.runtime.Composable | ||
import androidx.compose.ui.Modifier | ||
import androidx.compose.ui.graphics.Color | ||
import androidx.compose.ui.graphics.Shape | ||
import androidx.compose.ui.unit.Dp | ||
import androidx.compose.ui.unit.dp | ||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsTheme | ||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsTypography | ||
import team.aliens.dms.kmp.core.designsystem.text.DmsText | ||
|
||
@Composable | ||
fun DmsTag( | ||
modifier: Modifier = Modifier, | ||
text: String, | ||
contentPadding: PaddingValues = PaddingValues(horizontal = 16.dp, vertical = 6.dp), | ||
shape: Shape = RoundedCornerShape(24.dp), | ||
backgroundColor: Color = DmsTheme.colors.primary, | ||
contentColor: Color = DmsTheme.colors.inversePrimary, | ||
border: BorderStroke? = null, | ||
elevation: Dp = 0.dp, | ||
) { | ||
Surface( | ||
modifier = modifier, | ||
shape = shape, | ||
color = backgroundColor, | ||
contentColor = contentColor, | ||
border = border, | ||
elevation = elevation, | ||
) { | ||
DmsText( | ||
modifier = Modifier.padding(contentPadding), | ||
text = text, | ||
style = DmsTypography.Caption, | ||
color = DmsTheme.colors.inversePrimary, | ||
) | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
import org.jetbrains.kotlin.gradle.dsl.JvmTarget | ||
import team.aliens.dms.kmp.buildsrc.ProjectProperties | ||
import team.aliens.dms.kmp.buildsrc.Versions | ||
|
||
plugins { | ||
alias(libs.plugins.kotlinMultiplatform) | ||
alias(libs.plugins.androidLibrary) | ||
alias(libs.plugins.jetbrainsCompose) | ||
alias(libs.plugins.compose.compiler) | ||
alias(libs.plugins.ktlint) | ||
} | ||
|
||
kotlin { | ||
androidTarget { | ||
compilations.all { | ||
compileTaskProvider.configure { | ||
compilerOptions { | ||
jvmTarget.set(JvmTarget.JVM_17) | ||
} | ||
} | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 불필요한 공백 문자를 제거해 주세요. 파이프라인 검사에서 23번 줄에 불필요한 공백이 감지되었습니다. -
+ 🧰 Tools🪛 GitHub Actions: Kotlin Multiplatform CI[warning] 23-23: Trailing spaces detected |
||
listOf( | ||
iosX64(), | ||
iosArm64(), | ||
iosSimulatorArm64(), | ||
).forEach { | ||
it.binaries.framework { | ||
baseName = "outing" | ||
isStatic = true | ||
} | ||
} | ||
|
||
sourceSets { | ||
commonMain.dependencies { | ||
implementation(compose.runtime) | ||
implementation(compose.foundation) | ||
implementation(compose.material) | ||
implementation(compose.material3) | ||
implementation(compose.ui) | ||
implementation(libs.navigation.compose) | ||
|
||
implementation(libs.koin.core) | ||
implementation(libs.koin.compose) | ||
implementation(libs.koin.compose.viewmodel) | ||
|
||
implementation(projects.core.designSystem) | ||
implementation(projects.core.common) | ||
} | ||
commonTest.dependencies { | ||
implementation(libs.kotlin.test) | ||
} | ||
} | ||
} | ||
|
||
android { | ||
namespace = "team.aliens.dms.kmp.feature.outing" | ||
compileSdk = ProjectProperties.COMPILE_SDK | ||
defaultConfig { | ||
minSdk = ProjectProperties.MIN_SDK | ||
} | ||
compileOptions { | ||
sourceCompatibility = Versions.java | ||
targetCompatibility = Versions.java | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,34 @@ | ||||||||||||||||||||||||||
package team.aliens.dms.kmp.feature.outing | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
import androidx.compose.foundation.background | ||||||||||||||||||||||||||
import androidx.compose.foundation.layout.Arrangement | ||||||||||||||||||||||||||
import androidx.compose.foundation.layout.Column | ||||||||||||||||||||||||||
import androidx.compose.foundation.layout.fillMaxSize | ||||||||||||||||||||||||||
import androidx.compose.runtime.Composable | ||||||||||||||||||||||||||
import androidx.compose.ui.Modifier | ||||||||||||||||||||||||||
import team.aliens.dms.kmp.core.designsystem.appbar.DmsTopAppBar | ||||||||||||||||||||||||||
import team.aliens.dms.kmp.core.designsystem.foundation.DmsTheme | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
@Composable | ||||||||||||||||||||||||||
internal fun OutingApplication( | ||||||||||||||||||||||||||
modifier: Modifier = Modifier | ||||||||||||||||||||||||||
) { | ||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OutingApplication 구현이 필요합니다
다음과 같이 구현을 제안합니다: @Composable
internal fun OutingApplication(
- modifier: Modifier = Modifier
+ modifier: Modifier = Modifier,
) {
-
+ OutingApplicationScreen(
+ modifier = modifier,
+ )
} 📝 Committable suggestion
Suggested change
🧰 Tools🪛 detekt (1.23.7)[warning] 15-17: This empty block of code can be removed. (detekt.empty-blocks.EmptyFunctionBlock) 🪛 GitHub Actions: Kotlin Multiplatform CI[warning] 14-16: Missing trailing comma, unexpected blank line before '}', and empty first line in method block |
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
@Composable | ||||||||||||||||||||||||||
private fun OutingApplicationScreen( | ||||||||||||||||||||||||||
modifier: Modifier = Modifier, | ||||||||||||||||||||||||||
) { | ||||||||||||||||||||||||||
Column( | ||||||||||||||||||||||||||
modifier = modifier | ||||||||||||||||||||||||||
.fillMaxSize() | ||||||||||||||||||||||||||
.background(DmsTheme.colors.background), | ||||||||||||||||||||||||||
verticalArrangement = Arrangement.Center, | ||||||||||||||||||||||||||
) { | ||||||||||||||||||||||||||
DmsTopAppBar( | ||||||||||||||||||||||||||
title = "외출 신청", | ||||||||||||||||||||||||||
onBackPressed = { }, | ||||||||||||||||||||||||||
Comment on lines
+28
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 뒤로가기 동작이 구현되지 않았습니다
|
||||||||||||||||||||||||||
) | ||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
코드 스타일 개선이 필요합니다
파이프라인 실패를 해결하기 위해 trailing comma를 추가해 주세요.
다음과 같이 수정해 주세요:
📝 Committable suggestion
🧰 Tools
🪛 GitHub Actions: Kotlin Multiplatform CI
[warning] 23-23: Missing trailing comma before ')'