Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: [#282] ๋’ค๋กœ๊ฐ€๊ธฐ ์ˆ˜์ •, VC ํ˜ธ์ถœ ์˜ค๋ฅ˜ #283

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

Xixn2
Copy link
Member

@Xixn2 Xixn2 commented Nov 23, 2024

๐Ÿ’ก ๊ฐœ์š”

๋’ค๋กœ๊ฐ€๊ธฐ ์ˆ˜์ •, VC ํ˜ธ์ถœ ์˜ค๋ฅ˜

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • isVisible ํ”Œ๋ž˜๊ทธ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ๋ทฐ ์ปจํŠธ๋กค๋Ÿฌ์˜ ๊ฐ€์‹œ์„ฑ์„ ์ถ”์ ํ•˜๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • viewWillAppear์—์„œ isVisible์„ true๋กœ ์„ค์ •ํ•˜๊ณ , viewWillDisappear์—์„œ false๋กœ ์„ค์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋น„๋™๊ธฐ ์ž‘์—…์˜ ์™„๋ฃŒ ํ•ธ๋“ค๋Ÿฌ์—์„œ UI ์—…๋ฐ์ดํŠธ๋‚˜ ๋„ค๋น„๊ฒŒ์ด์…˜ ์Šคํƒ ๋ณ€๊ฒฝ ์ „์— isVisible ์—ฌ๋ถ€๋ฅผ ํ™•์ธํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํด๋กœ์ € ๋‚ด๋ถ€์—์„œ [weak self]๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ๋ฉ”๋ชจ๋ฆฌ ๋ˆ„์ˆ˜๋ฅผ ๋ฐฉ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์ƒˆ๋กœ๊ณ ์นจ ์ค‘ ๋‹ค๋ฅธ ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•ด๋„ ์ด์ „ ํ™”๋ฉด์œผ๋กœ ๋˜๋Œ์•„์˜ค์ง€ ์•Š๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ProfileView๊ฐ€ ๊ธฐ๋ณธ๊ฐ’์œผ๋กœ "ํ•™์ƒํšŒ"๋กœ ์ดˆ๊ธฐํ™” ๋˜์–ด์žˆ๋˜๊ฑธ ๊ถŒํ•œ์„ ํ™•์ธ ํ›„ ์ž…๋ ฅ๋˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

@Xixn2 Xixn2 added ๐Ÿ”ฅ | Hot Fix ๊ธ‰ํ•œ ์ˆ˜์ • ์ดํ›„ ๋ฐฐํฌ๊ฐ€ ํ•„์š”ํ•จ ๐Ÿ› ๏ธ | Bug Fix Bug or Issue ํ•ด๊ฒฐ ๐Ÿ”จ | Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง(๊ฐœ์„ ) ์ž‘์—… labels Nov 23, 2024
@Xixn2 Xixn2 self-assigned this Nov 23, 2024
Copy link
Contributor

@parkjungw0o parkjungw0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

@Xixn2 Xixn2 merged commit 81b5885 into develop Nov 25, 2024
1 check passed
@Xixn2 Xixn2 deleted the 282-QRScan-ErrorEdit branch November 25, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ› ๏ธ | Bug Fix Bug or Issue ํ•ด๊ฒฐ ๐Ÿ”ฅ | Hot Fix ๊ธ‰ํ•œ ์ˆ˜์ • ์ดํ›„ ๋ฐฐํฌ๊ฐ€ ํ•„์š”ํ•จ ๐Ÿ”จ | Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง(๊ฐœ์„ ) ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR๋ฒ„ํŠผ ๋’ค๋กœ๊ฐ€๊ธฐ๋กœ ๋ณ€๊ฒฝ
2 participants