Skip to content

Commit

Permalink
fix(a11y): making theme hidden input sr invisible
Browse files Browse the repository at this point in the history
  • Loading branch information
technikhil314 committed Sep 26, 2024
1 parent 218eb05 commit 52a0f39
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 7 additions & 1 deletion pages/v2/diff.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@
<div class="contents">
<div class="page-contents">
<!-- Following hidden input is hacky way to update monaco editor theme when user changes theme manually -->
<input type="hidden" inert :value="onThemeChange" />
<input
type="hidden"
class="invisible none"
aria-hidden="true"
inert
:value="onThemeChange"
/>
<Navbar :show-back-button="true" />
<main class="outline-none" tabindex="0">
<DiffActionBar :diff-navigator="diffNavigator" />
Expand Down
8 changes: 7 additions & 1 deletion pages/v2/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@
<div class="page-contents">
<Navbar />
<!-- Following hidden input is hacky way to update monaco editor theme when user changes theme manually -->
<input type="hidden" inert :value="onThemeChange" />
<input
type="hidden"
inert
:value="onThemeChange"
class="invisible none"
aria-hidden="true"
/>
<main class="text-gray-800 outline-none dark:text-gray-50" tabindex="0">
<section>
<header>
Expand Down

0 comments on commit 52a0f39

Please sign in to comment.