Remove close-attempt and expose new open property on detail for close events in Dialog and Drawer
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 9262e1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
packages/svelte-ux/src/routes/docs/components/Dialog/+page.svelte
Outdated
Show resolved
Hide resolved
techniq
requested changes
Aug 14, 2024
packages/svelte-ux/src/routes/docs/components/Dialog/+page.svelte
Outdated
Show resolved
Hide resolved
techniq
approved these changes
Aug 14, 2024
Merged
brandonmcconnell
changed the title
close and attemptClose methods as slot props from Dialogclose-attempt and expose new open property on detail for close events in Dialog and Drawer
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
close-attemptand expose newopenproperty ondetailforcloseevents inDialogandDrawer