fix jshint error and improve some features... #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformat code and fix jshint error replace console to $log updateOnBlur directive only use scope.$apply method when scope.$root.$$phase is null when destroy updateOnBlur directive, remove element event handler ( prevent memory leak ) add submit event handler to updateOnBlur directive ( check validation not only blur but also submit )
|
Sorry for the late reply and for your fixes. My file diff for the validation directive file shows everything has moved. Not sure why. If your changes are only related to using $log and fixing updateonblur i can selectively apply that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reformat code and fix jshint error
replace console to $log
updateOnBlur directive only use scope.$apply method when scope.$root.$$phase is null
when destroy updateOnBlur directive, remove element event handler ( prevent memory leak )
add submit event handler to updateOnBlur directive ( check validation not only blur but also submit )
add .gitignore ( ignore web storm or intelij files )