Small improvements #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraravam
reviewed
Dec 11, 2024
| @@ -39,20 +39,17 @@ These values are used in the code and in the following examples too. | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| The project requires [Java 21](https://adoptium.net/en-GB/). | |||
| The project requires [Java 21](https://adoptium.net/en-GB/). If you have multiple JVMs on your machine, you might want to consider | |||
| using a tool such as [sdkman](https://sdkman.io/) to handle switching between versions. | |||
There was a problem hiding this comment.
I would suggest to use mise instead of sdkman. It allows for:
- Multiple language-support
- can read language-specific package config files (for eg
.nvmrc) to then automatically provision the specific node version.
sdkman is only for java (i might be wrong), but it definitely does not handle the 2nd capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being fixed - and why?
Improves README for additional clarity and some better formatting.
PricePlanService- some things could be a little clearer.What has changed?
Does some reformatting in README. Mentions the possibility of using
sdkmanto manage JDK versions.Renames a couple of methods and some method variables in
PricePlanServiceto be closer to the actual problem space.