Fix rendering of units when used as defaults of plugin keys #3391
+93
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which happened to `reportportal` plugin in the last release, and the warning was not noticed in time. Doing it nicely called for adding a custom Jinja test, which deserves its documentation, which deserves its own section in our Jinja docs, which means renaming a couple of files and other changes. But it looks nice now.
happz
added
documentation
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which happened to
reportportalplugin in the last release, and the warning was not noticed in time. Doing it nicely called for adding a custom Jinja test, which deserves its documentation, which deserves its own section in our Jinja docs, which means renaming a couple of files and other changes. But it looks nice now.Pull Request Checklist