Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a new context dimension for image mode #3423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 12, 2024

Introduce a new context dimension key *****-mode in order to allow enabling/disabling/adjusting tests and plans based on the distribution mode.

Pull Request Checklist

  • update the specification
  • include a release note

Introduce a new context dimension key `*****-mode` in order to
allow enabling/disabling/adjusting tests and plans based on the
distribution mode.
@psss psss added the specification Metadata specification (core, tests, plans, stories) label Dec 12, 2024
@psss
Copy link
Collaborator Author

psss commented Dec 12, 2024

Two versions were proposed/discussed on the stakeholder session let's review, discuss both (or brainstorm more) and vote/select the final candidate here.

@psss psss added this to the 1.41 milestone Dec 12, 2024

image-mode
Flag denoting how new content is distributed. Use ``true``
for container images and ``false`` for standard packages.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vote here for image-mode.

@psss psss added the area | context The context adjust implementation label Dec 12, 2024
@comps
Copy link
Contributor

comps commented Jan 9, 2025

What about using an OS installation style instead?

If I understood it correctly, "image mode" is basically just rpm-ostree ( https://docs.fedoraproject.org/en-US/fedora-silverblue/technical-information/ ) built in some special way. So for tests (or other software on the system), the difference is not "distro mode" vs "image mode", but the visible filesystem structure the test sees, ie. "FHS / standard" vs "rpm-ostree".

The product name for that ("Atomic", "Silverblue", "image mode", .. ??) might be less relevant.

edit: Note that I'm not super familiar with "image mode", some docs mention it's based on ostree, but not 100% compatible with it.

@psss
Copy link
Collaborator Author

psss commented Jan 9, 2025

@kkaarreell, as you raised this topic on the stakeholder session, do you have any specific use cases on mind for e.g. enabling / disable tests based on this new dimension? Are they possibly related to the filesystem structure the test sees as @comps mentioned above?

@happz happz modified the milestones: 1.41, 1.42 Jan 13, 2025
@lukaszachy
Copy link
Collaborator

Can the dimension name be mode (or similar) with possible values image|package ?

@kkaarreell
Copy link
Collaborator

Can the dimension name be mode (or similar) with possible values image|package ?

Please don't. mode is so vague and overloaded term and maybe some users are already using it (mode=ro|rw|...). Please, make it at least a bit more specific and less prone to collisions. RH docs speaks about it as a deployment method. While deployment_method=package_mode|image_mode is long, it would be very much handy when inspecting logs or RP launch attributes, trying to identify how a test environment look like.

@kkaarreell
Copy link
Collaborator

@kkaarreell, as you raised this topic on the stakeholder session, do you have any specific use cases on mind for e.g. enabling / disable tests based on this new dimension? Are they possibly related to the filesystem structure the test sees as @comps mentioned above?

Yes, primarily test case filtering (enabling/disabling plans and tests).

@thrix
Copy link
Collaborator

thrix commented Jan 21, 2025

Can the dimension name be mode (or similar) with possible values image|package ?

@lukaszachy added to meeting agenda, but I am afraid you are outvoted :(

@lukaszachy
Copy link
Collaborator

lukaszachy commented Jan 21, 2025

Can the dimension name be mode (or similar) with possible values image|package ?

Please don't. mode is so vague and overloaded term and maybe some users are already using it (mode=ro|rw|...). Please, make it at least a bit more specific and less prone to collisions. RH docs speaks about it as a deployment method. While deployment_method=package_mode|image_mode is long, it would be very much handy when inspecting logs or RP launch attributes, trying to identify how a test environment look like.

I don't care if it is 'mode' or 'deployment_mode' as long as we don't have boolean '*-mode' representing each possibility.

@psss
Copy link
Collaborator Author

psss commented Jan 21, 2025

as long as we don't have boolean *-mode representing each possibility.

Yeah, I share this point with @lukaszachy. But, hopefully, there won't be that many deployment modes? Or? :)

@lukaszachy
Copy link
Collaborator

as long as we don't have boolean *-mode representing each possibility.

Yeah, I share this point with @lukaszachy. But, hopefully, there won't be that many deployment modes? Or? :)

More painful is that one would need to set at least two dimensions each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | context The context adjust implementation specification Metadata specification (core, tests, plans, stories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants