-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battle Gear 4 Key/RFID + IO Plus emulation #1086
base: master
Are you sure you want to change the base?
Conversation
… few bugs with taito JVS emulation
…caused by switch input fix
…rrotUI into bg4t-key-support
… key input into toggle
… loading from file stored with game config. Document protocol in code comments and allow config access from JVSPackageEmulator
…plement as stub to make response command length correct
This PR also addresses issue #960 |
Requesting a review on this PR. Is pretty much ready and has been tested extensively with a G27 and confirmed 6MT and sequential are both working as expected and all switches etc are also. Valve Limit R (another taito game that uses the same IO config roughly) is also unaffected. This is with one caveat however. There is a slight bug where you cannot push View and Hazard buttons at the same time, as well as the Overtake button turning the Key switch on (which is inverted by the game). This existed prior to this PR for SD mode and is due to how TP handles joystick inputs. Essentially TP disallows both Left+Right and Up+Down to be pressed at the same time. This is not an issue with traditional games that use the joystick inputs as intended but when they are used for switches this becomes an issue, especially if two in opposing directions need to be pressed independantly. I would like some maintainer/developer input here on how best I can work around this before merging. I imagine it is there due to traditional stick JVS games having the joystick physically limit which switches can be pressed (e.g. a joystick cannot physically press left+right or up+down at the same time) however this is not part of the JVS spec and I believe many JVS boards will pass physically "invalid" switch inputs like this without question. Once this is discussed and PR is merged I will mark the matching OpenParrot PR for review (if the OpenParrot one gets merged before this it will break BG4 tuned pro support). |
As title says, please see some taito-specific JVS commands that have been emulated which now allow key emulation to work properly with Battle Gear 4 Tuned without memory patches etc.
Two bugs have also been patched to ensure emulation lines up with real Universal JVS I/O packets:
With minor modification I would wager this is also applicable to other Taito Universal JVS I/O games (HL2 Survivor etc?).
Raising as a draft to tidy up/add a way to configure the key id, figure out unknown values, as well as ensure I havent broken anything. Would appreciate any comments/feedback! It is fully working in its current state from what I can see.