Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CopyConfigMapWithForceUpdate to CopyConfigMap #1829

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Rename CopyConfigMapWithForceUpdate to CopyConfigMap #1829

merged 1 commit into from
Nov 13, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 6, 2023 •
edited by jkandasa
Loading

This patch renames CopyConfigMapWithForceUpdate to CopyConfigMap and removes forceUpdate param
and always allow to add extra fields in ConfigMap

Fixes: #1568

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 6, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 71.8% 71.6% -0.2

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 71.8% 71.6% -0.2

@jkandasa
Copy link
Member

jkandasa commented Nov 9, 2023

@pratap0007 the tests are failing because the pkg/reconciler/common/transformers_test.go file not formatted correctly. You have removed some of the fields and the alignment changed. you have to reformat pkg/reconciler/common/transformers_test.go

@pratap0007 pratap0007 force-pushed the update-copy-cm branch 2 times, most recently from c7e7f79 to c9ef6b5 Compare November 9, 2023 06:23
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 71.8% 71.7% -0.1

@pratap0007
Rename CopyConfigMapWithForceUpdate to CopyConfigMap
33c1970 
This patch renames CopyConfigMapWithForceUpdate to CopyConfigMap
and removes `forceUpdate` param
and always allow to add extra fields in ConfigMap

Fixes: tektoncd#1568

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 71.8% 72.0% 0.3

jkandasa
jkandasa approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @pratap0007 🎉

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 13, 2023
@jkandasa
Copy link
Member

@pratap0007 It is a internal change, Hence I removed the release notes as user do not see the change.

@tekton-robot tekton-robot merged commit a698748 into tektoncd:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkandasa jkandasa jkandasa approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@jkandasa jkandasa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove "CopyConfigMap" transformer
3 participants
@pratap0007 @tekton-robot @jkandasa