Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to update PriorityClassName via options #1844

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 13, 2023

This patch sdds support to update PriorityClassName via options in Deployment and StatefulSet, also updates TektonConfig doc

Fixes: #1835

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Allow to update PriorityClassName via options in Deployment and StatefulSet

This patch sdds support to update PriorityClassName via options in Deployment
and StatefulSet, also updates TektonConfig doc

Fixes: tektoncd#1835

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 13, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 13, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformer_additional_options.go 89.9% 90.1% 0.2

Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@tekton-robot tekton-robot merged commit e5c4b7e into tektoncd:main Nov 13, 2023
2 checks passed
@jkandasa
Copy link
Member

thanks @pratap0007 👍

@jkandasa jkandasa added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "priorityClassName" under options in deployment and statefulset
3 participants