Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] ignore nested struct in AddConfigMapValues transformer #1848

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[main] ignore nested struct in AddConfigMapValues transformer #1848

merged 1 commit into from
Jan 31, 2024

Conversation

jkandasa
Copy link
Member

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Nov 15, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
piyush-garg
piyush-garg reviewed Nov 21, 2023
View reviewed changes
pkg/reconciler/common/transformers.go
continue
}

if value := values.Field(i).String(); value != "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this case handled ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg Sorry I have changed many thing on this PR. It should be WIP for now.
I am sorry for that. I will inform your when it is ready to review.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg Now it is ready to review. can you please review the PR?

@jkandasa jkandasa marked this pull request as draft November 21, 2023 05:10
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@jkandasa jkandasa changed the title ignore nested struct in AddConfigMapValues transformer [WIP] ignore nested struct in AddConfigMapValues transformer Nov 21, 2023
@jkandasa jkandasa force-pushed the fix_add_config_map_transformer branch from a27a8c8 to fa7e224 Compare January 17, 2024 23:54
@tektoncd tektoncd deleted a comment from tekton-robot Jan 17, 2024
@tektoncd tektoncd deleted a comment from tekton-robot Jan 17, 2024
@jkandasa jkandasa marked this pull request as ready for review January 18, 2024 01:35
@jkandasa jkandasa changed the title [WIP] ignore nested struct in AddConfigMapValues transformer ignore nested struct in AddConfigMapValues transformer Jan 18, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 72.0% 72.9% 0.9

@jkandasa jkandasa changed the title ignore nested struct in AddConfigMapValues transformer [main] ignore nested struct in AddConfigMapValues transformer Jan 18, 2024
@jkandasa jkandasa force-pushed the fix_add_config_map_transformer branch from fa7e224 to 957c2d2 Compare January 19, 2024 09:18
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 72.5% 73.3% 0.8

@jkandasa jkandasa force-pushed the fix_add_config_map_transformer branch from 957c2d2 to b80d515 Compare January 22, 2024 13:25
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 72.5% 73.3% 0.8

@jkandasa jkandasa force-pushed the fix_add_config_map_transformer branch from b80d515 to 6857650 Compare January 25, 2024 14:09
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/common/transformers.go 72.5% 73.3% 0.8

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@tekton-robot tekton-robot merged commit 91b4f76 into tektoncd:main Jan 31, 2024
8 checks passed
@jkandasa jkandasa deleted the fix_add_config_map_transformer branch February 1, 2024 01:33
@jkandasa jkandasa added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore struct data type in "AddConfigMapValues" transformer
4 participants
@jkandasa @tekton-robot @piyush-garg @vdemeester