Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feature flags for pipeline #1890

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Update feature flags for pipeline #1890

merged 1 commit into from
Dec 14, 2023

Conversation

piyush-garg
Copy link
Contributor

This will update feature flags of pipeline component to be compatible with latest 0.54 release of pipeline

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Update feature flags for pipeline

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 5, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 90.7% 93.2% 2.5
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 81.8% 80.6% -1.2

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 90.7% 93.2% 2.5
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 81.8% 80.6% -1.2

@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
jkandasa
jkandasa reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-garg thanks for the PR.

Can you please add a documentation about the new variables?

pkg/apis/operator/v1alpha1/tektonpipeline_validation.go Show resolved Hide resolved
pkg/apis/operator/v1alpha1/tektonpipeline_types.go Show resolved Hide resolved
vdemeester
vdemeester reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkandasa @concaf do we want to keep those in since or do we want to deprecate them and rely on additionnal fields in the future ?

@piyush-garg
Update feature flags for pipeline
8fa298f 
This will update feature flags of pipeline component to
be compatible with latest 0.54 release of pipeline

Add docs for the new fields added.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonpipeline_defaults.go 90.7% 93.2% 2.5
pkg/apis/operator/v1alpha1/tektonpipeline_validation.go 81.8% 80.6% -1.2

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-operator-integration-tests

@jkandasa
Copy link
Member

@jkandasa @concaf do we want to keep those in since or do we want to deprecate them and rely on additionnal fields in the future ?

IMHO, We can rely on options (additional fields). No need to work on new fields

@piyush-garg WDYT?

@piyush-garg
Copy link
Contributor Author

@jkandasa @concaf do we want to keep those in since or do we want to deprecate them and rely on additionnal fields in the future ?

IMHO, We can rely on options (additional fields). No need to work on new fields

@piyush-garg WDYT?

Sure we should more move towards options. For now, we can have this for consistency and in future release, we need to mark them deprecated and provide migration during upgrade that whatever specified will be moved to options so smooth upgrade and no action items on user.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
concaf
concaf approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@concaf concaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: concaf, jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 44e64cd into tektoncd:main Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@jkandasa jkandasa jkandasa approved these changes

@concaf concaf concaf approved these changes

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@concaf concaf

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piyush-garg @tekton-robot @PuneetPunamiya @jkandasa @vdemeester @concaf