Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added filesystem-custom-path to allowed x509 fulcio providers #1909

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Added filesystem-custom-path to allowed x509 fulcio providers #1909

merged 1 commit into from
Jan 2, 2024

Conversation

sabre1041
Copy link
Contributor

Changes

Added filesystem-custom-path to allowed x509 fulcio providers for Tekton Chains

Relevant PR: tektoncd/chains#727

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Adds "filesystem-custom-path" to the list of allowed Chains Fulcio x509 providers

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 22, 2023
@tekton-robot
Copy link
Contributor

Hi @sabre1041. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2023
vdemeester
vdemeester approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @PuneetPunamiya @concaf

@tekton-robot tekton-robot requested a review from concaf December 22, 2023 11:52
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@jkandasa
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2023
@PuneetPunamiya
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@tekton-robot tekton-robot merged commit 92fc112 into tektoncd:main Jan 2, 2024
@jkandasa jkandasa mentioned this pull request Feb 26, 2024
Merged
4 tasks
@jkandasa
Copy link
Member

@sabre1041 we are going to revert this change via #2030, If you have a concern please start a discussion

@sabre1041
Copy link
Contributor Author

I am good with reverting. Under the covers, this option is used but it is not exposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@concaf concaf Awaiting requested review from concaf

Assignees

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabre1041 @tekton-robot @jkandasa @PuneetPunamiya @vdemeester