Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable fips compliance on openshift operator #2429

Merged
merged 1 commit into from
Dec 5, 2024
Merged

enable fips compliance on openshift operator #2429

merged 1 commit into from
Dec 5, 2024

Conversation

jkhelil
Copy link
Member

@jkhelil jkhelil commented Nov 28, 2024 •
edited by jkandasa
Loading

Changes

Enable FIPS compliance on openshift operator

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 28, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2024
jkandasa
jkandasa approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @vdemeester

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 28, 2024
@jkhelil
Copy link
Member Author

jkhelil commented Dec 2, 2024

@vdemeester @savitaashture ptal

savitaashture
savitaashture reviewed Dec 2, 2024
View reviewed changes
...penshift/manifests/bases/openshift-pipelines-operator-rh.clusterserviceversion.template.yaml
@@ -11,7 +11,7 @@ metadata:
description: Red Hat OpenShift Pipelines is a cloud-native CI/CD solution for building pipelines using Tekton concepts which run natively on OpenShift and Kubernetes.
operators.operatorframework.io/builder: operator-sdk-v1.7.2
features.operators.openshift.io/disconnected: "true"
features.operators.openshift.io/fips-compliant: "false"
features.operators.openshift.io/fips-compliant: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you point to any doc to read about this annotation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check here: https://docs.openshift.com/dedicated/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-annotations-infra_osdk-generating-csvs

@savitaashture
Copy link
Contributor

cc @khrm can we merge this ??

vdemeester
vdemeester approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, savitaashture, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jkandasa,savitaashture,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit bf1b049 into tektoncd:main Dec 5, 2024
8 checks passed
@savitaashture
Copy link
Contributor

/cherry-pick release-v0.74.x

@tekton-robot
Copy link
Contributor

@savitaashture: new pull request created: #2536

In response to this:

/cherry-pick release-v0.74.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@savitaashture savitaashture savitaashture approved these changes

@jkandasa jkandasa jkandasa approved these changes

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jkhelil @savitaashture @tekton-robot @vdemeester @khrm @jkandasa