Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly failures #2475

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

afrittoli
Copy link
Member

Changes

When updating nightly builds to use ghcr.io, the work workspace is bound in the pipeline which is causing an auth failure when images are pushed to ghcr.io.

Fix that to restore nightly builds.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

When updating nightly builds to use ghcr.io, the work workspace
is bound in the pipeline which is causing an auth failure when
images are pushed to ghcr.io.

Fix that to restore nightly builds.

Signed-off-by: Andrea Frittoli <[email protected]>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 29, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2024
@afrittoli
Copy link
Member Author

afrittoli commented Dec 29, 2024

This is needed to fix nightly builds.

Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@tekton-robot tekton-robot merged commit 387bd07 into tektoncd:main Dec 30, 2024
8 checks passed
@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/cherry-pick release-v0.73.x
/cherry-pick release-v0.74.x

@tekton-robot
Copy link
Contributor

@jkhelil: new pull request created: #2499

In response to this:

/cherry-pick release-v0.73.x
/cherry-pick release-v0.74.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkhelil
Copy link
Member

jkhelil commented Jan 11, 2025

/cherry-pick release-v0.74.x

@tekton-robot
Copy link
Contributor

@jkhelil: new pull request created: #2504

In response to this:

/cherry-pick release-v0.74.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants