Fix ghcr.io auth in release #2491
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
|
/test pull-tekton-operator-build-tests |
1 similar comment
|
/test pull-tekton-operator-build-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-operator-build-tests |
|
It looks like linting is broken, I wonder if that's due to changes to the test image @vdemeester |
|
/test pull-tekton-operator-build-tests |
afrittoli
force-pushed
the
fix_release_typo
branch
from
27956d8 to
70ea621
Compare
|
/test pull-tekton-operator-build-tests |
@jkhelil unfortunately this isn't a flake, the linter is broken, probably due to updates to the test image. I've been trying to figure out how to fix that, it looks like we might need a new version of golangci-lint in the test image. |
|
@vdemeester @jkhelil @tektoncd/operator-maintainers I'm tempted to change things this way:
WDYT? PR: #2493 |
Yeah I think this change makes sense 👍🏻 |
A typo in an env variable cause auth failure when pushing to ghcr.io in the release process. Fix that to restore nightly builds and full releases. Add some cosmetic changes to cleanup up the release pipeline log files. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
fix_release_typo
branch
from
70ea621 to
0f97ef4
Compare
|
@jkhelil - once CI is green, it'll need an LGTM 🙏 |
|
/lgtm |
|
/cherry-pick release-v0.73.x |
|
@jkhelil: new pull request created: #2500 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v0.74.x |
|
@jkhelil: new pull request created: #2505 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
A typo in an env variable cause auth failure when pushing to ghcr.io in the release process. Fix that to restore nightly builds and full releases.
Add some cosmetic changes to cleanup up the release pipeline log files.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes