Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get tektonconfig version from label #2518

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

l-qing
Copy link
Contributor

@l-qing l-qing commented Jan 17, 2025

When the managedFields field is present in the TektonConfig CR, the kubectl get tektonconfig config -o yaml command returns multiple operator.tekton.dev/release-version labels. This causes the tektonconfig_version_from_label function to return an incorrect version. This commit fixes the issue by adding a head -n 1 command to the grep command in the tektonconfig_version_from_label function.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

When the `managedFields` field is present in the TektonConfig CR, the
`kubectl get tektonconfig config -o yaml` command returns multiple
`operator.tekton.dev/release-version` labels. This causes the
`tektonconfig_version_from_label` function to return an incorrect
version. This commit fixes the issue by adding a `head -n 1` command
to the `grep` command in the `tektonconfig_version_from_label` function.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 17, 2025
@tekton-robot
Copy link
Contributor

Hi @l-qing. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
@pratap0007
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 20, 2025
@jkhelil
Copy link
Member

jkhelil commented Jan 20, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@tekton-robot tekton-robot merged commit 8039f5b into tektoncd:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants